linux-kernel - Re: [PATCH v2 0/3] Adding support for trace events to habanalabs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220822105240.3cb3002c@gandalf.local.home>
Date:   Mon, 22 Aug 2022 10:52:40 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Oded Gabbay <ogabbay@...nel.org>
Cc:     linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH v2 0/3] Adding support for trace events to habanalabs

On Sun, 21 Aug 2022 11:06:05 +0300
Oded Gabbay <ogabbay@...nel.org> wrote:

> Thanks for your comments. We have fixed the patches according to them.
> 
> You wrote the first patch is r-b, but I took the liberty to add your r-b to
> all three patches, I hope you don't object.

I usually only add the r-b to the patches that add TRACE_EVENT(), and
sometimes to those that modify them. Because that's what I know best. The
usage of the trace events is usually subsystem specific and I tend not to
add a r-b for them because people might think I understand how they are
being used ;-)

But in this case, since I did recommend some tricks in those extra patches,
you can keep the tag for them.

Here's my disclaimer for all these patches:

***

Reviewed only from the tracing point of view, I have no idea if the content
held in the trace is correct or not.

***

;-)

-- Steve