linux-kernel - Re: [PATCH 1/4] soc: qcom: qmi: use const for struct qmi_elem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <79580753-6290-2da4-2949-c408333b8af5@quicinc.com>
Date:   Mon, 22 Aug 2022 08:14:39 -0700
From:   Jeff Johnson <quic_jjohnson@...cinc.com>
To:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>
CC:     <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 1/4] soc: qcom: qmi: use const for struct qmi_elem_info

please ignore this, rookie git send-email mistake

On 8/22/2022 8:11 AM, Jeff Johnson wrote:
> Currently all usage of struct qmi_elem_info, which is used to define
> the QMI message encoding/decoding rules, does not use const. This
> prevents clients from registering const arrays. Since these arrays are
> always pre-defined, they should be const, so add the const qualifier
> to all places in the QMI interface where struct qmi_elem_info is used.
> 
> Once this patch is in place, clients can independently update their
> pre-defined arrays to be const, as demonstrated in the QMI sample
> code.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> ---
> 
> v2:
> Added missing const to skip_to_next_elem() return type
> Reported-by: kernel test robot <lkp@...el.com>