linux-kernel - Re: [PATCH] arm64: dts: rockchip: Pull up wlan wake# on Gru-Bob

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=VJ7GxRstF06aCSJH4mCdqWrLtp8_VhyhkMkxhkP9nL-g@mail.gmail.com>
Date:   Mon, 22 Aug 2022 17:10:36 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Brian Norris <briannorris@...omium.org>
Cc:     Heiko Stuebner <heiko@...ech.de>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Pull up wlan wake# on Gru-Bob

Hi,

On Mon, Aug 22, 2022 at 4:45 PM Brian Norris <briannorris@...omium.org> wrote:
>
> The Gru-Bob board does not have a pull-up resistor on its
> WLAN_HOST_WAKE# pin, but Kevin does. The production/vendor kernel
> specified the pin configuration correctly as a pull-up, but this didn't
> get ported correctly to upstream.
>
> This means Bob's WLAN_HOST_WAKE# pin is floating, causing inconsistent
> wakeup behavior.
>
> Note that bt_host_wake_l has a similar dynamic, but apparently the
> upstream choice was to redundantly configure both internal and external
> pull-up on Kevin (see the "Kevin has an external pull up" comment in
> rk3399-gru.dtsi). This doesn't cause any functional problem, although
> it's perhaps wasteful.
>
> Fixes: 8559bbeeb849 ("arm64: dts: rockchip: add Google Bob")
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> ---
>
>  arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts         | 5 +++++
>  arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi | 1 +
>  2 files changed, 6 insertions(+)

Reviewed-by: Douglas Anderson <dianders@...omium.org>