linux-kernel - Re: [PATCH] Split multiple assignments to individual lines.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220823084133.GG2695@kadam>
Date:   Tue, 23 Aug 2022 11:41:34 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc:     Christopher Carbone <chris.m.carbone@...il.com>,
        sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
        gregkh@...uxfoundation.org, linux-fbdev@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Split multiple assignments to individual lines.

On Mon, Aug 22, 2022 at 08:05:57PM +0200, Philipp Hortmann wrote:
> I personally prefer more this:
> 
> > +	sm750_dev->fbinfo[1] = NULL;
> > +	sm750_dev->fbinfo[0] = NULL;
> 
> That gives a better overview.
> 

Same for everywhere.  Literals are clear than variables.

 Bad:	foo = bar;
Good:	foo = -1;

Avoid pointless indirection.

regards,
dan carpenter