linux-kernel - [PATCH -next] x86: i8259: Make default_legacy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220823021958.3052493-1-chenlifu@huawei.com>
Date:   Tue, 23 Aug 2022 10:19:58 +0800
From:   Chen Lifu <chenlifu@...wei.com>
To:     <tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>,
        <dave.hansen@...ux.intel.com>, <x86@...nel.org>, <hpa@...or.com>,
        <linux-kernel@...r.kernel.org>
CC:     <chenlifu@...wei.com>
Subject: [PATCH -next] x86: i8259: Make default_legacy_pic static

The symbol is not used outside of the file, so mark it static.

Fixes the following warning:

arch/x86/kernel/i8259.c:410:19: warning:
	symbol 'default_legacy_pic' was not declared. Should it be static?

Signed-off-by: Chen Lifu <chenlifu@...wei.com>
---
 arch/x86/kernel/i8259.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/i8259.c b/arch/x86/kernel/i8259.c
index 15aefa3f3e18..3aa5304200c5 100644
--- a/arch/x86/kernel/i8259.c
+++ b/arch/x86/kernel/i8259.c
@@ -405,11 +405,11 @@ struct legacy_pic null_legacy_pic = {
 	.probe = legacy_pic_probe,
 	.irq_pending = legacy_pic_irq_pending_noop,
 	.make_irq = legacy_pic_uint_noop,
 };
 
-struct legacy_pic default_legacy_pic = {
+static struct legacy_pic default_legacy_pic = {
 	.nr_legacy_irqs = NR_IRQS_LEGACY,
 	.chip  = &i8259A_chip,
 	.mask = mask_8259A_irq,
 	.unmask = unmask_8259A_irq,
 	.mask_all = mask_8259A,
-- 
2.37.1