[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220822202147.4be904de@kernel.org>
Date: Mon, 22 Aug 2022 20:21:47 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Frank <Frank.Sae@...or-comm.com>
Cc: Peter Geis <pgwipeout@...il.com>, Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, yinghong.zhang@...or-comm.com,
fei.zhang@...or-comm.com, hua.sun@...or-comm.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4.4] net: phy: Add driver for Motorcomm yt8521 gigabit
ethernet phy
On Wed, 17 Aug 2022 19:25:54 +0800 Frank wrote:
> +static int yt8521_fiber_config_aneg(struct phy_device *phydev)
> +{
> + int err, changed;
> + u16 adv;
> +
> + if (phydev->autoneg != AUTONEG_ENABLE)
> + return yt8521_fiber_setup_forced(phydev);
> +
> + err = ytphy_modify_ext_with_lock(phydev, YTPHY_MISC_CONFIG_REG,
> + YTPHY_MCR_FIBER_SPEED_MASK,
> + YTPHY_MCR_FIBER_1000BX);
> + if (err < 0)
> + return err;
> +
> + /* enable Fiber auto sensing */
> + err = ytphy_modify_ext_with_lock(phydev, YT8521_LINK_TIMER_CFG2_REG,
> + 0, YT8521_LTCR_EN_AUTOSEN);
> + if (err < 0)
> + return err;
> +
> + /* Setup fiber advertisement */
> + adv = ADVERTISE_1000XFULL | ADVERTISE_1000XPAUSE |
> + ADVERTISE_1000XPSE_ASYM;
Is it okay to ignore phydev->advertising and always set the same mask?
> + err = phy_modify_changed(phydev, MII_ADVERTISE,
> + ADVERTISE_1000XHALF | ADVERTISE_1000XFULL |
> + ADVERTISE_1000XPAUSE | ADVERTISE_1000XPSE_ASYM,
> + adv);
Powered by blists - more mailing lists