linux-kernel - RE: [PATCH] exfat: fix overflow for large capacity partition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <55c001d8b6a0$2d1ce2c0$8756a840$@samsung.com>
Date:   Tue, 23 Aug 2022 12:26:47 +0900
From:   "Sungjong Seo" <sj1557.seo@...sung.com>
To:     "'Namjae Jeon'" <linkinjeon@...nel.org>
Cc:     "'linux-fsdevel'" <linux-fsdevel@...r.kernel.org>,
        "'linux-kernel'" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] exfat: fix overflow for large capacity partition

> Using int type for sector index, there will be overflow in a large
> capacity partition.
> 
> For example, if storage with sector size of 512 bytes and partition
> capacity is larger than 2TB, there will be overflow.
> 
> Fixes: 1b6138385499 ("exfat: reduce block requests when zeroing a cluster")
> 
> Signed-off-by: Yuezhang Mo <Yuezhang.Mo@...y.com>
> Reviewed-by: Andy Wu <Andy.Wu@...y.com>
> Reviewed-by: Aoyama Wataru <wataru.aoyama@...y.com>

Looks good!
Acked-by: Sungjong Seo <sj1557.seo@...sung.com>

> 
> ---
>  fs/exfat/fatent.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/exfat/fatent.c b/fs/exfat/fatent.c index
> ee0b7cf51157..41ae4cce1f42 100644
> --- a/fs/exfat/fatent.c
> +++ b/fs/exfat/fatent.c
> @@ -270,8 +270,7 @@ int exfat_zeroed_cluster(struct inode *dir, unsigned
> int clu)
>  	struct super_block *sb = dir->i_sb;
>  	struct exfat_sb_info *sbi = EXFAT_SB(sb);
>  	struct buffer_head *bh;
> -	sector_t blknr, last_blknr;
> -	int i;
> +	sector_t blknr, last_blknr, i;
> 
>  	blknr = exfat_cluster_to_sector(sbi, clu);
>  	last_blknr = blknr + sbi->sect_per_clus;
> --
> 2.25.1