linux-kernel - Re: [PATCH v2 1/8] memblock tests: update tests to check if memblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6382c2d4-ac0b-644e-4c69-8650afe30bb9@redhat.com>
Date:   Tue, 23 Aug 2022 11:36:57 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Rebecca Mckeever <remckee0@...il.com>,
        Mike Rapoport <rppt@...nel.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Cc:     Shaoqin Huang <shaoqin.huang@...el.com>
Subject: Re: [PATCH v2 1/8] memblock tests: update tests to check if
 memblock_alloc zeroed memory

On 19.08.22 10:34, Rebecca Mckeever wrote:
> Add an assert in memblock_alloc() tests where allocation is expected to
> occur. The assert checks whether the entire chunk of allocated memory is
> cleared.
> 
> The current memblock_alloc() tests do not check whether the allocated
> memory was zeroed. memblock_alloc() should zero the allocated memory since
> it is a wrapper for memblock_alloc_try_nid().
> 
> Reviewed-by: Shaoqin Huang <shaoqin.huang@...el.com>
> Signed-off-by: Rebecca Mckeever <remckee0@...il.com>

Reviewed-by: David Hildenbrand <david@...hat.com>


-- 
Thanks,

David / dhildenb