linux-kernel - [PATCH 1/2] liburing: Change the type of `flags` in `io_uring_prep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220823114813.2865890-2-ammar.faizi@intel.com>
Date:   Tue, 23 Aug 2022 18:52:43 +0700
From:   Ammar Faizi <ammarfaizi2@...weeb.org>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     Ammar Faizi <ammarfaizi2@...weeb.org>,
        io-uring Mailing List <io-uring@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        Bart Van Assche <bvanassche@....org>,
        Dylan Yudaken <dylany@...com>,
        Facebook Kernel Team <kernel-team@...com>,
        Kanna Scarlet <knscarlet@...weeb.org>
Subject: [PATCH 1/2] liburing: Change the type of `flags` in `io_uring_prep_renameat()` to `unsigned int`

From: Ammar Faizi <ammarfaizi2@...weeb.org>

Sync with the declaration of `renameat2()` from the man page.

Closes: https://github.com/axboe/liburing/pull/615
Link: https://man7.org/linux/man-pages/man2/rename.2.html
Signed-off-by: Ammar Faizi <ammarfaizi2@...weeb.org>
---
 man/io_uring_prep_renameat.3 | 4 ++--
 src/include/liburing.h       | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/man/io_uring_prep_renameat.3 b/man/io_uring_prep_renameat.3
index 1fc9e01..08d4a46 100644
--- a/man/io_uring_prep_renameat.3
+++ b/man/io_uring_prep_renameat.3
@@ -16,12 +16,12 @@ io_uring_prep_renameat \- prepare a renameat request
 .BI "                            const char *" oldpath ","
 .BI "                            int " newdirfd ","
 .BI "                            const char *" newpath ","
-.BI "                            int " flags ");"
+.BI "                            unsigned int " flags ");"
 .PP
 .BI "void io_uring_prep_rename(struct io_uring_sqe *" sqe ","
 .BI "                          const char *" oldpath ","
 .BI "                          const char *" newpath ","
-.BI "                          int " flags ");"
+.BI "                          unsigned int " flags ");"
 .fi
 .SH DESCRIPTION
 .PP
diff --git a/src/include/liburing.h b/src/include/liburing.h
index 06f4a50..df748aa 100644
--- a/src/include/liburing.h
+++ b/src/include/liburing.h
@@ -862,7 +862,7 @@ static inline void io_uring_prep_unlink(struct io_uring_sqe *sqe,
 
 static inline void io_uring_prep_renameat(struct io_uring_sqe *sqe, int olddfd,
 					  const char *oldpath, int newdfd,
-					  const char *newpath, int flags)
+					  const char *newpath, unsigned int flags)
 {
 	io_uring_prep_rw(IORING_OP_RENAMEAT, sqe, olddfd, oldpath,
 				(__u32) newdfd,
-- 
Ammar Faizi