linux-kernel - Re: [PATCH] arm64: dts: qcom: sc7280: move USB wakeup-source property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YwS7ndGJ5cgERJhz@hovoldconsulting.com>
Date:   Tue, 23 Aug 2022 13:35:57 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Johan Hovold <johan+linaro@...nel.org>, andersson@...nel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Sandeep Maheswaram <quic_c_sanm@...cinc.com>,
        Krishna Kurapati <quic_kriskura@...cinc.com>,
        Pavankumar Kondeti <quic_pkondeti@...cinc.com>,
        quic_ppratap@...cinc.com, quic_vpulyala@...cinc.com,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: move USB wakeup-source property

On Mon, Aug 22, 2022 at 03:31:21PM -0700, Matthias Kaehlcke wrote:
> On Mon, Aug 22, 2022 at 03:13:54PM +0200, Johan Hovold wrote:
> > On Tue, Aug 02, 2022 at 05:26:42PM +0200, Johan Hovold wrote:
> > > Move the USB-controller wakeup-source property to the dwc3 glue node to
> > > match the updated binding.
> > > 
> > > Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> > > ---
> > > 
> > > This one can be applied once the following series has been merged:
> > > 
> > > 	https://lore.kernel.org/all/20220802151404.1797-1-johan+linaro@kernel.org
> > 
> > The above series has now been merged (for 6.0):
> > 
> > 	https://lore.kernel.org/all/Yv56fFpuUsxCSxJ8@kroah.com/
> > 
> > so that this patch can be applied.
> 
> Please apply it together with "clk: qcom: gcc-sc7280: Keep USB GDSC power
> domains on when USB wakeup is enabled" [1], otherwise USB wakeup won't work,
> and worse, USB would be broken after returning from system suspend.

If you really need [1] for wakeup to work then it's already broken as
the hack added to 6.0-rc1 that kept the power domain on in suspend has
been reverted.

If [1] is also needed for USB to work after resume, we either have a
bigger problem as I alluded to in my comment to [1] (and the PD needs to
be always on) or this is due to the PHY no longer being powered down in
suspend.

Only in the latter case, does this patch need to be held of until [1]
has been merged AFAICT.

Johan

> [1] https://patchwork.kernel.org/project/linux-arm-msm/patch/20220822115246.2.If09027f73daa6e1ed95f5eab02326b543c67132e@changeid/