linux-kernel - Re: [PATCH] s390: move from strlcpy with unused retval to strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Aug 2022 14:45:52 +0200
From:   Vasily Gorbik <gor@...ux.ibm.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-kernel@...r.kernel.org, Stefan Haberland <sth@...ux.ibm.com>,
        Jan Hoeppner <hoeppner@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Vineeth Vijayan <vneethv@...ux.ibm.com>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Alexandra Winter <wintera@...ux.ibm.com>,
        Wenjia Zhang <wenjia@...ux.ibm.com>,
        Steffen Maier <maier@...ux.ibm.com>,
        Benjamin Block <bblock@...ux.ibm.com>,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] s390: move from strlcpy with unused retval to strscpy

On Mon, Aug 22, 2022 at 06:02:49PM -0700, Jakub Kicinski wrote:
> On Thu, 18 Aug 2022 23:01:01 +0200 Wolfram Sang wrote:
> > Follow the advice of the below link and prefer 'strscpy' in this
> > subsystem. Conversion is 1:1 because the return value is not used.
> > Generated by a coccinelle script.
> > 
> > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> > Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> > ---
> >  drivers/s390/block/dasd_devmap.c | 2 +-
> >  drivers/s390/block/dasd_eer.c    | 4 ++--
> >  drivers/s390/block/dcssblk.c     | 2 +-
> >  drivers/s390/char/hmcdrv_cache.c | 2 +-
> >  drivers/s390/char/tape_class.c   | 4 ++--
> >  drivers/s390/cio/qdio_debug.c    | 2 +-
> >  drivers/s390/net/ctcm_main.c     | 2 +-
> >  drivers/s390/net/fsm.c           | 2 +-
> >  drivers/s390/net/qeth_ethtool.c  | 4 ++--
> >  drivers/s390/scsi/zfcp_aux.c     | 2 +-
> >  drivers/s390/scsi/zfcp_fc.c      | 2 +-
> 
> I'm assuming this will go via the s390 tree?

Yes, I'll just take it via s390 tree. Thanks

> 
> Acked-by: Jakub Kicinski <kuba@...nel.org>
> 
> If nobody picks it up please feel free to resend the networking parts to us.