linux-kernel - Re: [PATCH linux-next v2] mm/slub: Remove the unneeded result variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <42323fe6-3ac1-4dff-cf49-6e97525df837@suse.cz>
Date:   Tue, 23 Aug 2022 16:08:57 +0200
From:   Vlastimil Babka <vbabka@...e.cz>
To:     cgel.zte@...il.com, 42.hyeyoo@...il.com
Cc:     cl@...ux.com, penberg@...nel.org, rientjes@...gle.com,
        iamjoonsoo.kim@....com, akpm@...ux-foundation.org,
        roman.gushchin@...ux.dev, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next v2] mm/slub: Remove the unneeded result
 variable

On 8/22/22 03:38, cgel.zte@...il.com wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> Return the value from attribute->store(s, buf, len) and
> attribute->show(s, buf) directly instead of storing it in
> another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Acked-by: Hyeonggon Yoo <42.hyeyoo@...il.com>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>

Thanks, added to slab.git for-6.1/trivial

> ---
> v1 -> v2
> Add the whitespace between subsystem and summary in subject line.
>  mm/slub.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index 6953c3367bc2..7bea010a20ff 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -5852,7 +5852,6 @@ static ssize_t slab_attr_show(struct kobject *kobj,
>  {
>  	struct slab_attribute *attribute;
>  	struct kmem_cache *s;
> -	int err;
>  
>  	attribute = to_slab_attr(attr);
>  	s = to_slab(kobj);
> @@ -5860,9 +5859,7 @@ static ssize_t slab_attr_show(struct kobject *kobj,
>  	if (!attribute->show)
>  		return -EIO;
>  
> -	err = attribute->show(s, buf);
> -
> -	return err;
> +	return attribute->show(s, buf);
>  }
>  
>  static ssize_t slab_attr_store(struct kobject *kobj,
> @@ -5871,7 +5868,6 @@ static ssize_t slab_attr_store(struct kobject *kobj,
>  {
>  	struct slab_attribute *attribute;
>  	struct kmem_cache *s;
> -	int err;
>  
>  	attribute = to_slab_attr(attr);
>  	s = to_slab(kobj);
> @@ -5879,8 +5875,7 @@ static ssize_t slab_attr_store(struct kobject *kobj,
>  	if (!attribute->store)
>  		return -EIO;
>  
> -	err = attribute->store(s, buf, len);
> -	return err;
> +	return attribute->store(s, buf, len);
>  }
>  
>  static void kmem_cache_release(struct kobject *k)