linux-kernel - Re: [PATCH] drm/exynos: fix repeated words in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48f4a56f-0586-9e9d-c121-6309be65b803@arm.com>
Date:   Tue, 23 Aug 2022 14:36:56 +0100
From:   Robin Murphy <robin.murphy@....com>
To:     Jilin Yuan <yuanjilin@...rlc.com>, airlied@...ux.ie,
        daniel@...ll.ch, krzysztof.kozlowski@...aro.org
Cc:     dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/exynos: fix repeated words in comments

On 2022-08-23 13:21, Jilin Yuan wrote:
>   Delete the redundant word 'next'.

 From the context, I'm not sure it is redundant - as far as I can tell 
this comment seems to be describing a sequence of 3 commands, where 
"current" is the first, "next" is the second, and "next next" implies 
the third. The whole comment could certainly be reworded more clearly, 
but as it stands I suspect a replacement like s/next next/next+1/ is 
more likely to be correct.

Robin.

> Signed-off-by: Jilin Yuan <yuanjilin@...rlc.com>
> ---
>   drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> index 471fd6c8135f..4f9edca66632 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> @@ -1195,7 +1195,7 @@ int exynos_g2d_set_cmdlist_ioctl(struct drm_device *drm_dev, void *data,
>   	 * If don't clear SFR registers, the cmdlist is affected by register
>   	 * values of previous cmdlist. G2D hw executes SFR clear command and
>   	 * a next command at the same time then the next command is ignored and
> -	 * is executed rightly from next next command, so needs a dummy command
> +	 * is executed rightly from next command, so needs a dummy command
>   	 * to next command of SFR clear command.
>   	 */
>   	cmdlist->data[cmdlist->last++] = G2D_SOFT_RESET;