linux-kernel - Re: [PATCH] drm/msm/dp: Silence inconsistent indent warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8a2f675-4d69-58f7-a603-5e810f0077fe@quicinc.com>
Date:   Tue, 23 Aug 2022 10:47:02 -0700
From:   Abhinav Kumar <quic_abhinavk@...cinc.com>
To:     Stephen Boyd <swboyd@...omium.org>,
        Rob Clark <robdclark@...il.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Sean Paul <sean@...rly.run>
CC:     <linux-kernel@...r.kernel.org>, <patches@...ts.linux.dev>,
        <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>,
        Kuogee Hsieh <quic_khsieh@...cinc.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] drm/msm/dp: Silence inconsistent indent warning

Hi Stephen

On 8/22/2022 7:43 PM, Stephen Boyd wrote:
> Build robots complain
> 
>   smatch warnings:
>   drivers/gpu/drm/msm/dp/dp_link.c:969 dp_link_process_link_status_update() warn: inconsistent indenting
> 
> Fix it.
> 
> Cc: Kuogee Hsieh <quic_khsieh@...cinc.com>
> Fixes: ea530388e64b ("drm/msm/dp: skip checking LINK_STATUS_UPDATED bit")

This patch itself LGTM. But when I was looking at the fixes commit, I 
noticed one more formatting issue.

There seems to be an extra space character in this part.

diff --git a/drivers/gpu/drm/msm/dp/dp_link.c 
b/drivers/gpu/drm/msm/dp/dp_link.c
index 49d7fad36fc4..be986da78c4a 100644
--- a/drivers/gpu/drm/msm/dp/dp_link.c
+++ b/drivers/gpu/drm/msm/dp/dp_link.c
@@ -773,7 +773,8 @@ static int 
dp_link_process_link_training_request(struct dp_link_private *link)
                         link->request.test_lane_count);

         link->dp_link.link_params.num_lanes = 
link->request.test_lane_count;
-       link->dp_link.link_params.rate = link->request.test_link_rate;
+       link->dp_link.link_params.rate =
+               drm_dp_bw_code_to_link_rate(link->request.test_link_rate);

         return 0;

Since we are fixing up this commit, can you please fix this too?

Thanks

Abhinav
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
>   drivers/gpu/drm/msm/dp/dp_link.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c
> index 36f0af02749f..1620110806cf 100644
> --- a/drivers/gpu/drm/msm/dp/dp_link.c
> +++ b/drivers/gpu/drm/msm/dp/dp_link.c
> @@ -965,8 +965,7 @@ static int dp_link_process_link_status_update(struct dp_link_private *link)
>   	if (channel_eq_done && clock_recovery_done)
>   		return -EINVAL;
>   
> -
> -       return 0;
> +	return 0;
>   }
>   
>   /**
> 
> base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868