linux-kernel - Re: [PATCH v2] cpufreq: check only freq_table in __resolve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jQpEL7SMjj83fbm-Afz7D7Wj41g5AFa2-8zoeehnRppg@mail.gmail.com>
Date:   Tue, 23 Aug 2022 20:02:14 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Lukasz Luba <lukasz.luba@....com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH v2] cpufreq: check only freq_table in __resolve_freq()

On Tue, Aug 16, 2022 at 2:02 PM Lukasz Luba <lukasz.luba@....com> wrote:
>
> There is no need to check if the cpufreq driver implements callback
> cpufreq_driver::target_index. The logic in the __resolve_freq uses
> the frequency table available in the policy. It doesn't matter if the
> driver provides 'target_index' or 'target' callback. It just has to
> populate the 'policy->freq_table'.
>
> Thus, check only frequency table during the frequency resolving call.
>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> Signed-off-by: Lukasz Luba <lukasz.luba@....com>
> ---
> Changes:
> v2:
> - collected ACK from Viresh
> - corrected patch description (Viresh)
>
>
>  drivers/cpufreq/cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 7820c4e74289..69b3d61852ac 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -532,7 +532,7 @@ static unsigned int __resolve_freq(struct cpufreq_policy *policy,
>
>         target_freq = clamp_val(target_freq, policy->min, policy->max);
>
> -       if (!cpufreq_driver->target_index)
> +       if (!policy->freq_table)
>                 return target_freq;
>
>         idx = cpufreq_frequency_table_target(policy, target_freq, relation);
> --

Applied as 6.0-rc material, thanks!