linux-kernel - Re: [PATCH v4] regulator: dt-bindings: mediatek: add mt6366

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220823184705.6fdpczguait2la4v@notapiano>
Date:   Tue, 23 Aug 2022 14:47:05 -0400
From:   Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>
To:     Zhiyong Tao <zhiyong.tao@...iatek.com>
Cc:     lee.jones@...aro.org, robh+dt@...nel.org, matthias.bgg@...il.com,
        lgirdwood@...il.com, broonie@...nel.org, eddie.huang@...iatek.com,
        a.zummo@...ertech.it, alexandre.belloni@...tlin.com,
        fshao@...omium.org, sen.chu@...iatek.com, hui.liu@...iatek.com,
        allen-kh.cheng@...iatek.com, hsin-hsiung.wang@...iatek.com,
        sean.wang@...iatek.com, macpaul.lin@...iatek.com,
        wen.su@...iatek.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v4] regulator: dt-bindings: mediatek: add mt6366

On Tue, Aug 23, 2022 at 08:37:45PM +0800, Zhiyong Tao wrote:
> Add mt6366 regulator document
> 
> Signed-off-by: Zhiyong Tao <zhiyong.tao@...iatek.com>
> ---
[..]
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml
[..]
> +      "^buck-(vcore)-sshub$":

The parentheses here don't serve any purpose, so drop them.

> +        type: object
> +        $ref: regulator.yaml#
> +        unevaluatedProperties: false
[..]
> +      "^ldo-vcn(33)-wifi$":

Ditto.

> +        type: object
> +        $ref: regulator.yaml#
> +        unevaluatedProperties: false
> +
> +      "^ldo-vsram-(others)-sshub$":

Ditto.

> +        type: object
> +        $ref: regulator.yaml#
> +        unevaluatedProperties: false
[..]
> +      "^ldo-vsim[2]$":

Based on the example, should be [12].

Thanks,
Nícolas

> +        type: object
[..]
> +            mt6366_vsim1_reg: ldo-vsim1 {
> +                regulator-enable-ramp-delay = <540>;
> +            };
[..]
> +            mt6366_vsim2_reg: ldo-vsim2 {
> +                regulator-enable-ramp-delay = <540>;
> +            };
[..]