lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Aug 2022 21:19:52 +0100 From: "Russell King (Oracle)" <linux@...linux.org.uk> To: Andrew Lunn <andrew@...n.ch> Cc: Jakub Kicinski <kuba@...nel.org>, Frank <Frank.Sae@...or-comm.com>, Peter Geis <pgwipeout@...il.com>, Heiner Kallweit <hkallweit1@...il.com>, "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, yinghong.zhang@...or-comm.com, fei.zhang@...or-comm.com, hua.sun@...or-comm.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v4.4] net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy On Tue, Aug 23, 2022 at 08:53:54PM +0200, Andrew Lunn wrote: > > > The user could of changed the pause settings, which are going to be > > > ignored here. Also, you should not assume the MAC can actually do > > > asymmetric pause, not all can. phydev->advertising will be set to only > > > include what the MAC can actually do. > > > Interesting. Just to confirm - regardless of the two-sided design.. > > -edness.. IIUC my question has merit and we need v5? > > Yes, phydev->advertising should be take into account. It's worth pointing out that there is a helper for this - linkmode_adv_to_mii_adv_x(). -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists