[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YwVjpTW6vWvdVQTK@ZenIV>
Date: Wed, 24 Aug 2022 00:32:53 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc: Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
Chaitanya Kulkarni <kch@...dia.com>,
James Smart <james.smart@...adcom.com>,
Ira Weiny <ira.weiny@...el.com>,
"Venkataramanan, Anirudh" <anirudh.venkataramanan@...el.com>,
linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
Chaitanya Kulkarni <chaitanyak@...dia.com>,
Keith Busch <kbusch@...nel.org>
Subject: Re: [PATCH v3 1/1] nvmet-tcp: Don't kmap() pages which can't come
from HIGHMEM
On Mon, Aug 22, 2022 at 04:24:38PM +0200, Fabio M. De Francesco wrote:
> Therefore, replace the kmap() of sg_page(sg) with a page_address() and
> delete the "nr_mapped" field from "nvmet_tcp_cmd" and instead pass a
> local variable to iov_iter_kvec() from the call site in
> nvmet_tcp_map_pdu_iovec().
I'd suggest looking into switching to ITER_BVEC...
Powered by blists - more mailing lists