linux-kernel - [PATCH linux-next v2] qnx4: delete the unnecessary checks before brelse()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220823075147.208942-1-ye.xingchen@zte.com.cn>
Date:   Tue, 23 Aug 2022 07:51:47 +0000
From:   cgel.zte@...il.com
To:     al@...rsen.net, linux-kernel@...r.kernel.org
Cc:     ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: [PATCH linux-next v2] qnx4: delete the unnecessary checks before brelse()

From: ye xingchen <ye.xingchen@....com.cn>

The brelse() function tests whether its argument is NULL
and then returns immediately.
Thus remove the tests which are not needed around the shown calls.

Reported-by: Zeal Robot <zealci@....com.cn>
Acked-by: Anders Larsen <al@...rsen.net>
Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
---
v1 -> v2
Decrease the indentation of the following line.
 fs/qnx4/inode.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/qnx4/inode.c b/fs/qnx4/inode.c
index 391ea402920d..7d2a9de8c55d 100644
--- a/fs/qnx4/inode.c
+++ b/fs/qnx4/inode.c
@@ -118,8 +118,7 @@ unsigned long qnx4_block_map( struct inode *inode, long iblock )
 				bh = NULL;
 			}
 		}
-		if ( bh )
-			brelse( bh );
+		brelse(bh);
 	}
 
 	QNX4DEBUG((KERN_INFO "qnx4: mapping block %ld of inode %ld = %ld\n",iblock,inode->i_ino,block));
-- 
2.25.1