linux-kernel - Re: [PATCH -next] soc: qcom: Make QCOM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0848eb00-5e32-3d2d-0c07-a1fd09164bd9@infradead.org>
Date:   Mon, 22 Aug 2022 18:21:29 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     YueHaibing <yuehaibing@...wei.com>, agross@...nel.org,
        bjorn.andersson@...aro.org, konrad.dybcio@...ainline.org
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] soc: qcom: Make QCOM_RPMPD depend on OF



On 8/20/22 04:32, YueHaibing wrote:
> WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS_OF
>   Depends on [n]: PM_GENERIC_DOMAINS [=y] && OF [=n]
>   Selected by [m]:
>   - QCOM_RPMPD [=m] && PM [=y] && QCOM_SMD_RPM [=m]
> 
> PM_GENERIC_DOMAINS_OF depends on OF, so QCOM_RPMPD also depends on it.
> 
> Fixes: 7d0221fb5912 ("soc/qcom: Make QCOM_RPMPD select PM_GENERIC_DOMAINS/_OF")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Works for me. Thanks.

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

> ---
>  drivers/soc/qcom/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index e0d7a5459562..024e420f1bb7 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -129,7 +129,7 @@ config QCOM_RPMHPD
>  
>  config QCOM_RPMPD
>  	tristate "Qualcomm RPM Power domain driver"
> -	depends on PM
> +	depends on PM && OF
>  	depends on QCOM_SMD_RPM
>  	select PM_GENERIC_DOMAINS
>  	select PM_GENERIC_DOMAINS_OF

-- 
~Randy