linux-kernel - Re: [PATCH v10 0/6] Raspberry Pi Sense HAT driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62ea701c-4a4d-876e-f9b5-db9013b38f04@i2se.com>
Date:   Wed, 24 Aug 2022 20:21:34 +0200
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Charles Mirabile <cmirabil@...hat.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Peter Robinson <pbrobinson@...il.com>,
        Serge Schneider <serge@...pberrypi.org>,
        Nicolas Saenz Julienne <nicolassaenzj@...il.com>,
        Mattias Brugger <mbrugger@...e.com>,
        linux-rpi-kernel@...ts.infradead.org,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        rh-kdlp@...glegroups.com, Joel Slebodnick <jslebodn@...hat.com>,
        Joel Savitz <jsavitz@...hat.com>,
        Maxime Ripard <maxime@...no.tech>,
        Noralf Trønnes <noralf@...nnes.org>
Subject: Re: [PATCH v10 0/6] Raspberry Pi Sense HAT driver

Am 24.08.22 um 14:06 schrieb Charles Mirabile:
>> In case you want to send a new version it would be nice to enable the
>> driver in bcm2835_defconfig for better test coverage. But this is not a
>> show stopper.
> Since I am going to have to send a v11 to fix Lee's email address I
> will look into this. Is it as simple as adding another patch that puts
> CONFIG_SENSEHAT_DISPLAY=y into the next version?
> Presumably I would also want to enable CONFIG_JOYSTICK_SENSEHAT right?
> Do I have to do anything special since both of those options have
> decencies (namely CONFIG_I2C for both and CONFIG_INPUT for the latter,
> and both select MFD_SIMPLE_MFD_I2C)?

make bcm2835_defconfig

enable both driver via make menuconfig

make savedefconfig

mv defconfig arch/arm/configs/bcm2835_defconfig.2

diff -u arch/arm/configs/bcm2835_defconfig 
arch/arm/configs/bcm2835_defconfig.2 > config.patch

manually add only the relevant changes from config.patch in 
arch/arm/configs/bcm2835_defconfig

generate the patch as usual

goal is to have simple patch which only contains the 2 driver changes 
without any clean-up changes