linux-kernel - Re: [PATCH -next] parisc: ccio-dma: Add missing iounmap in error path in ccio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <559e9805-3e38-fa50-d3ce-5eee317832bf@gmx.de>
Date:   Wed, 24 Aug 2022 21:20:50 +0200
From:   Helge Deller <deller@....de>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-kernel@...r.kernel.org, linux-parisc@...r.kernel.org
Cc:     liqiong@...china.com
Subject: Re: [PATCH -next] parisc: ccio-dma: Add missing iounmap in error path
 in ccio_probe()

On 8/24/22 11:36, Yang Yingliang wrote:
> Add missing iounmap() before return from ccio_probe(), if ccio_init_resources()
> fails.
>
> Fixes: d46c742f827f ("parisc: ccio-dma: Handle kmalloc failure in ccio_init_resources()")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

applied.
Thanks!
Helge


> ---
>  drivers/parisc/ccio-dma.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/parisc/ccio-dma.c b/drivers/parisc/ccio-dma.c
> index f223afe47d10..a66386043aa6 100644
> --- a/drivers/parisc/ccio-dma.c
> +++ b/drivers/parisc/ccio-dma.c
> @@ -1546,6 +1546,7 @@ static int __init ccio_probe(struct parisc_device *dev)
>  	}
>  	ccio_ioc_init(ioc);
>  	if (ccio_init_resources(ioc)) {
> +		iounmap(ioc->ioc_regs);
>  		kfree(ioc);
>  		return -ENOMEM;
>  	}