linux-kernel - Re: [PATCH] video: fbdev: omap: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b696b6cc-7cd4-4f62-6289-6f29c1e40214@gmx.de>
Date:   Wed, 24 Aug 2022 21:56:22 +0200
From:   Helge Deller <deller@....de>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     linux-fbdev@...r.kernel.org, linux-omap@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] video: fbdev: omap: Remove unnecessary print function
 dev_err()

On 8/24/22 13:44, Jiapeng Chong wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> ./drivers/video/fbdev/omap/omapfb_main.c:1653:2-9: line 1653 is redundant because platform_get_irq() already prints an error.
> ./drivers/video/fbdev/omap/omapfb_main.c:1646:2-9: line 1646 is redundant because platform_get_irq() already prints an error.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1957
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

applied.

Thanks!
Helge

> ---
>  drivers/video/fbdev/omap/omapfb_main.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
> index fbb3af883d4d..17cda5765683 100644
> --- a/drivers/video/fbdev/omap/omapfb_main.c
> +++ b/drivers/video/fbdev/omap/omapfb_main.c
> @@ -1643,14 +1643,12 @@ static int omapfb_do_probe(struct platform_device *pdev,
>  	}
>  	fbdev->int_irq = platform_get_irq(pdev, 0);
>  	if (fbdev->int_irq < 0) {
> -		dev_err(&pdev->dev, "unable to get irq\n");
>  		r = ENXIO;
>  		goto cleanup;
>  	}
>
>  	fbdev->ext_irq = platform_get_irq(pdev, 1);
>  	if (fbdev->ext_irq < 0) {
> -		dev_err(&pdev->dev, "unable to get irq\n");
>  		r = ENXIO;
>  		goto cleanup;
>  	}