linux-kernel - Re: [PATCH -next 1/2] rv/monitors: add 'static' qualifier for local symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5688e47a-fc2c-457c-fa78-071733bf06f3@kernel.org>
Date:   Wed, 24 Aug 2022 08:33:25 +0200
From:   Daniel Bristot de Oliveira <bristot@...nel.org>
To:     Zeng Heng <zengheng4@...wei.com>, mingo@...hat.com,
        rostedt@...dmis.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next 1/2] rv/monitors: add 'static' qualifier for local
 symbols

On 8/24/22 05:43, Zeng Heng wrote:
> The sparse tool complains as follows:
> 
> kernel/trace/rv/monitors/wwnr/wwnr.c:18:19:
> warning: symbol 'rv_wwnr' was not declared. Should it be static?
> 
> The `rv_wwnr` symbol is not dereferenced by other extern files,
> so add static qualifier for it.
> 
> So does wip module.
> 
> Fixes:	ccc319dcb450 ("rv/monitor: Add the wwnr monitor")
> Fixes:	8812d21219b9 ("rv/monitor: Add the wip monitor skeleton created by dot2k")
> Signed-off-by: Zeng Heng <zengheng4@...wei.com>

Acked-by: Daniel Bristot de Oliveira <bristot@...nel.org>

Thanks!
-- Daniel