linux-kernel - Re: [PATCH] cxl: Replace HDM decoder granularity magic numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Aug 2022 10:44:01 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Davidlohr Bueso <dave@...olabs.net>
CC:     Adam Manzanares <a.manzanares@...sung.com>,
        "alison.schofield@...el.com" <alison.schofield@...el.com>,
        "vishal.l.verma@...el.com" <vishal.l.verma@...el.com>,
        "ira.weiny@...el.com" <ira.weiny@...el.com>,
        "widawsk@...nel.org" <widawsk@...nel.org>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "linux-cxl@...r.kernel.org" <linux-cxl@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cxl: Replace HDM decoder granularity magic numbers

On Mon, 22 Aug 2022 10:17:03 -0700
Davidlohr Bueso <dave@...olabs.net> wrote:

> On Mon, 22 Aug 2022, Adam Manzanares wrote:
> 
> >When reviewing the CFMWS parsing code that deals with the HDM decoders,
> >I noticed a couple of magic numbers. This commit replaces these magic numbers
> >with constants defined by the CXL 2.0 specification.  
> 
> Please use 3.0 spec :)
> 
> Actually the whole drivers/cxl/* could use updating the comments for 3.0.

Interesting point.  What do we want to do on this?  Most similar
cases I've been involved on rely on referring to 'oldest' compatible spec.
(this is true for ACPI stuff for example).

I don't care either way, but a policy on this will save us some time
by ensuring we meet that policy before sending for review.

Jonathan