lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Aug 2022 12:06:22 +0200 From: Pavel Machek <pavel@....cz> To: Hans de Goede <hdegoede@...hat.com> Cc: PaddyKP_Yao <ispaddy@...il.com>, PaddyKP_Yao@...s.com, acpi4asus-user@...ts.sourceforge.net, andy.shevchenko@...il.com, corentin.chary@...il.com, linux-kernel@...r.kernel.org, luke@...nes.dev, mgross@...ux.intel.com, platform-driver-x86@...r.kernel.org Subject: Re: [PATCH v3 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support Hi! > > LED is present by checking WMI ASUS_WMI_DEVID_MICMUTE_LED, we will add a > > mic-mute LED classdev, asus::micmute, in the asus-wmi driver to control > > it. The binding of mic-mute LED controls will be swithched with LED > > trigger. > > > > Signed-off-by: PaddyKP_Yao <PaddyKP_Yao@...s.com> > > --- > > V1 -> V2: fix typo for 'present' and remove unnecessary pr_info() log > > V2 -> V3: resend patch again by gmail to avoid Asus legal in the mail > > Thank you for your patch, I've applied this patch to my review-hans > branch: > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans > > Once I've run some tests on this branch the patches there will be > added to the platform-drivers-x86/for-next branch and eventually > will be included in the pdx86 pull-request to Linus for the next > merge-window. > > + if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MICMUTE_LED)) { > > + asus->micmute_led.name = "asus::micmute"; It would be good to get the API right before it hits mainline release. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Powered by blists - more mailing lists