linux-kernel - Re: [PATCH v3] cachefiles: fix error return code in cachefiles_ondemand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3700079.1661336363@warthog.procyon.org.uk>
Date:   Wed, 24 Aug 2022 11:19:23 +0100
From:   David Howells <dhowells@...hat.com>
To:     Sun Ke <sunke32@...wei.com>
Cc:     dhowells@...hat.com, linux-cachefs@...hat.com,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, jefflexu@...ux.alibaba.com
Subject: Re: [PATCH v3] cachefiles: fix error return code in cachefiles_ondemand_copen()

	/* fail OPEN request if copen format is invalid */
	ret = kstrtol(psize, 0, &size);
	if (ret) {
		req->error = ret;
		goto out;
	}

	/* fail OPEN request if daemon reports an error */
	if (size < 0) {
		if (!IS_ERR_VALUE(size))
			ret = size = -EINVAL;
		req->error = size;
		goto out;
	}

Should ret get set to the error in size?

David