linux-kernel - Re: [PATCH v2 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220824111734.GA8434@AA2000783-NB2.corpnet.asus>
Date:   Wed, 24 Aug 2022 19:17:34 +0800
From:   PaddyKP Yao <ispaddy@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Pavel Machek <pavel@....cz>, PaddyKP_Yao@...s.com,
        andy.shevchenko@...il.com, acpi4asus-user@...ts.sourceforge.net,
        corentin.chary@...il.com, linux-kernel@...r.kernel.org,
        luke@...nes.dev, mgross@...ux.intel.com,
        platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v2 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev
 support

Hi Hans,

On Wed, Aug 24, 2022 at 01:11:32PM +0200, Hans de Goede wrote:
> Yes. Since I have already merged your original patch can you please make
> this a new patch on top of your original patch ?  In other words just
> make this 1 small change in the new patch:
> 
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 2d9d709aa59f..18e584eb9f0f 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -1060,7 +1060,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
>  	}
>  
>  	if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MICMUTE_LED)) {
> -		asus->micmute_led.name = "asus::micmute";
> +		asus->micmute_led.name = "platform::micmute";
>  		asus->micmute_led.max_brightness = 1;
>  		asus->micmute_led.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE);
>  		asus->micmute_led.brightness_set_blocking = micmute_led_set;
> 
> Regards,
> 
> Hans
> 

Thanks for your advice.
No problem, I will fix it soon.

Best Regards, Paddy