linux-kernel - RE: [EXT] Re: [PATCH] octeontx2-pf: Add egress PFC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 24 Aug 2022 12:46:00 +0000
From:   Suman Ghosh <sumang@...vell.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH] octeontx2-pf: Add egress PFC support

>> >> -	schq = hw->txschq_list[lvl][0];
>> >> +#ifdef CONFIG_DCB
>> >> +	if (txschq_for_pfc)
>> >> +		schq = pfvf->pfc_schq_list[lvl][prio];
>> >> +	else
>> >> +#endif
>> >
>> >Please could you try to remove as many of these #ifdef CONFIG_DCB as
>> >possible. It makes build testing less efficient at finding build
>> >problems. Can you do:
>> >
>> >> +	if (IS_ENABLED(CONFIG_DCB) && txschq_for_pfc)
>> >> +		schq = pfvf->pfc_schq_list[lvl][prio];
>> >
>> [Suman] I will restructured the code. But we cannot use
>> pfvf->pfc_schq_list outside #ifdef CONFIG_DCB as these are defined
>> under the macro in otx2_common.h
>
>So maybe add a getter and setter in otx2_common.h, which returns -
>EOPNOTSUPP or similar when CONFIG_DCB is disabled?
>
>	    Andrew
[Suman] I have updated the patch and using CONFIG_DCB only once in the function. Can you please check if that should be okay?