linux-kernel - Re: [PATCH 3/4] arm64: dts: ti: Add initial support for J784s4 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25820bbe-c232-fb5c-0654-fc917ed8ad92@linaro.org>
Date:   Wed, 24 Aug 2022 15:47:30 +0300
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Nishanth Menon <nm@...com>
Cc:     Apurva Nandan <a-nandan@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        Hari Nagalla <hnagalla@...com>
Subject: Re: [PATCH 3/4] arm64: dts: ti: Add initial support for J784s4 SoC

On 24/08/2022 08:02, Nishanth Menon wrote:
> On 13:18-20220823, Krzysztof Kozlowski wrote:
>>> +	main_gpio_intr: interrupt-controller@...000 {
>>> +		compatible = "ti,sci-intr";
>>> +		reg = <0x00 0x00a00000 0x00 0x800>;
>>
>> 0x0, not 0x00. Here and all other places.
> 
> 
> Krzysztof is this a convention we have started following strongly?
> 
> The reason I ask is to be able to cleanup elsewhere in the dts as well..
> 
> 
> So far, I have insisted on 0x00 usage.

Not really, just stick to one. Your other nodes have 0x0, so just choose
one. Anyway additional zeros seem redundant, but it is up to you which
convention you prefer. Just choose one, not mixed.

Best regards,
Krzysztof