linux-kernel - Re: [PATCH] rtc: mpfs: Use devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c14607d5-337c-3e75-2b95-720553f40282@wanadoo.fr>
Date:   Wed, 24 Aug 2022 15:25:30 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Conor.Dooley@...rochip.com, Daire.McNamara@...rochip.com,
        a.zummo@...ertech.it, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-rtc@...r.kernel.org
Subject: Re: [PATCH] rtc: mpfs: Use devm_clk_get_enabled() helper

Le 24/08/2022 à 14:28, Alexandre Belloni a écrit :
> 
> BTW, I thought you actually tested your changes on the other patch I
> took, not that you were doing a blanket conversion of the subsystem.
> This is the kind of info that must appear in the commit log. I would
> definitively not have taken the patch.
> 

Ok, noted for future contribution.

In fact I first sent only one patch to see if it got some interest for 
such transformation.
I only sent some other after your Ack.

Nothing is never trivial, but such patches looks fine to me.
It saves some LoC, reduce the size of the .o and slightly saves some 
runtime memory.

And unless, I missed something, the order of operation remains the same, 
both when resources are allocated and freed.

Why wouldn't you have taken such a patch?
(just for my understanding and in order to avoid spamming others with 
useless/risky stuff)

CJ