linux-kernel - RE: [PATCH] pinctrl: amd: Pick some different unicode symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Aug 2022 13:51:47 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Mario Limonciello' <mario.limonciello@....com>,
        Basavaraj Natikar <Basavaraj.Natikar@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        Linus Walleij <linus.walleij@...aro.org>
CC:     Kent Gibson <warthog618@...il.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] pinctrl: amd: Pick some different unicode symbols

From: Mario Limonciello
> Sent: 24 August 2022 00:08
> 
> Feedback from Kent had showed some better selections for symbols to
> use for pinctrl-amd debugfs output.  Adopt some of those instead.

I hope I'm never the person you tries to write a test script
to check the output....
Or describe them to someone else...

	David

> Fixes: e8129a076a50 ("pinctrl: amd: Use unicode for debugfs output")

The best 'fix' is to remove all the stupid characters.

> Suggested-by: Kent Gibson <warthog618@...il.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
>  drivers/pinctrl/pinctrl-amd.c | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
> index 4691a33bc374..fda41907c4f1 100644
> --- a/drivers/pinctrl/pinctrl-amd.c
> +++ b/drivers/pinctrl/pinctrl-amd.c
> @@ -246,7 +246,7 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
>  		}
>  		seq_printf(s, "GPIO bank%d\n", bank);
>  		for (; i < pin_num; i++) {
> -			seq_printf(s, "📌%d\t", i);
> +			seq_printf(s, "#%d\t", i);
>  			raw_spin_lock_irqsave(&gpio_dev->lock, flags);
>  			pin_reg = readl(gpio_dev->base + i * 4);
>  			raw_spin_unlock_irqrestore(&gpio_dev->lock, flags);
> @@ -278,32 +278,32 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
>  			}
> 
>  			if (pin_reg & BIT(INTERRUPT_MASK_OFF))
> -				interrupt_mask = "-";
> +				interrupt_mask = "😛";
>  			else
> -				interrupt_mask = "+";
> -			seq_printf(s, "int %s (🎭 %s)| active-%s| %s-🔫| ",
> +				interrupt_mask = "😷";
> +			seq_printf(s, "int %s (%s)| active-%s| %s-⚡| ",
>  				   interrupt_enable,
>  				   interrupt_mask,
>  				   active_level,
>  				   level_trig);
> 
>  			if (pin_reg & BIT(WAKE_CNTRL_OFF_S0I3))
> -				wake_cntrl0 = "+";
> +				wake_cntrl0 = "⏰";
>  			else
> -				wake_cntrl0 = "∅";
> -			seq_printf(s, "S0i3 🌅 %s| ", wake_cntrl0);
> +				wake_cntrl0 = " ∅";
> +			seq_printf(s, "S0i3 %s| ", wake_cntrl0);
> 
>  			if (pin_reg & BIT(WAKE_CNTRL_OFF_S3))
> -				wake_cntrl1 = "+";
> +				wake_cntrl1 = "⏰";
>  			else
> -				wake_cntrl1 = "∅";
> -			seq_printf(s, "S3 🌅 %s| ", wake_cntrl1);
> +				wake_cntrl1 = " ∅";
> +			seq_printf(s, "S3 %s| ", wake_cntrl1);
> 
>  			if (pin_reg & BIT(WAKE_CNTRL_OFF_S4))
> -				wake_cntrl2 = "+";
> +				wake_cntrl2 = "⏰";
>  			else
> -				wake_cntrl2 = "∅";
> -			seq_printf(s, "S4/S5 🌅 %s| ", wake_cntrl2);
> +				wake_cntrl2 = " ∅";
> +			seq_printf(s, "S4/S5 %s| ", wake_cntrl2);
> 
>  			if (pin_reg & BIT(PULL_UP_ENABLE_OFF)) {
>  				pull_up_enable = "+";
> @@ -367,7 +367,7 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
>  				debounce_enable = "  ∅";
>  			}
>  			snprintf(debounce_value, sizeof(debounce_value), "%u", time * unit);
> -			seq_printf(s, "debounce %s (⏰ %sus)| ", debounce_enable, debounce_value);
> +			seq_printf(s, "debounce %s (🕑 %sus)| ", debounce_enable, debounce_value);
>  			seq_printf(s, " 0x%x\n", pin_reg);
>  		}
>  	}
> --
> 2.34.1

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)