linux-kernel - Re: [PATCH linux-next] scsi: lpfc: Remove the unneeded result variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9caed19e-ec83-92d3-cc86-586cc01f2fee@gmail.com>
Date:   Wed, 24 Aug 2022 07:14:23 -0700
From:   James Smart <jsmart2021@...il.com>
To:     cgel.zte@...il.com, martin.petersen@...cle.com
Cc:     james.smart@...adcom.com, dick.kennedy@...adcom.com,
        jejb@...ux.ibm.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] scsi: lpfc: Remove the unneeded result
 variable

On 8/24/2022 12:50 AM, cgel.zte@...il.com wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> Return the value from lpfc_sli4_issue_wqe() directly instead of storing it
>   in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
>   drivers/scsi/lpfc/lpfc_sli.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index 608016725db9..1298cea81396 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -10322,12 +10322,10 @@ static int
>   __lpfc_sli_issue_fcp_io_s4(struct lpfc_hba *phba, uint32_t ring_number,
>   			   struct lpfc_iocbq *piocb, uint32_t flag)
>   {
> -	int rc;
>   	struct lpfc_io_buf *lpfc_cmd = piocb->io_buf;
>   
>   	lpfc_prep_embed_io(phba, lpfc_cmd);
> -	rc = lpfc_sli4_issue_wqe(phba, lpfc_cmd->hdwq, piocb);
> -	return rc;
> +	return lpfc_sli4_issue_wqe(phba, lpfc_cmd->hdwq, piocb);
>   }
>   
>   void

Thanks

Reviewed-by: James Smart <jsmart2021@...il.com>

-- james