linux-kernel - Re: [PATCH] scsi: ufs: ufsfbo: Introduce File Based Optimization feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <347dae29c07fe13e6974b0e59e127c399f63ef69.camel@gmail.com>
Date:   Wed, 24 Aug 2022 16:16:35 +0200
From:   Bean Huo <huobean@...il.com>
To:     Jiaming Li <lijiamingsofine@...il.com>, avri.altman@....com,
        alim.akhtar@...sung.com, jejb@...ux.ibm.com, bvanassche@....org
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        lijiaming3 <lijiaming3@...omi.com>
Subject: Re: [PATCH] scsi: ufs: ufsfbo: Introduce File Based Optimization
 feature

On Wed, 2022-08-24 at 16:46 +0800, Jiaming Li wrote:
> From: lijiaming3 <lijiaming3@...omi.com>
> 
> Implement File Based Optimization initialization and add sysfs
> interface.
> 
> Stoage devices have a long lifespan. Device performance over its
> lifespan is not constant and may deteriorate over time
> 
> This feature describes a method to improve the performance
> regression.
> The host needs to provide File System information to storage device
> first. Based on that information device analyzes the file system data
> and provides the host the level of performance regression. The host
> then may instruct the device to execute optimization procedure to
> improve the regression level.
> 
> Signed-off-by: lijiaming3 <lijiaming3@...omi.com>
> ---
>  arch/arm64/configs/defconfig |    1 +
>  drivers/scsi/ufs/Kconfig     |    9 +
>  drivers/scsi/ufs/Makefile    |    1 +
>  drivers/scsi/ufs/ufs.h       |   13 +
>  drivers/scsi/ufs/ufsfbo.c    | 1007
> ++++++++++++++++++++++++++++++++++
>  drivers/scsi/ufs/ufsfbo.h    |  143 +++++
>  drivers/scsi/ufs/ufshcd.c    |   15 +
>  drivers/scsi/ufs/ufshcd.h    |    7 +-
>  8 files changed, 1195 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/scsi/ufs/ufsfbo.c
>  create mode 100644 drivers/scsi/ufs/ufsfbo.h
> 
> diff --git a/arch/arm64/configs/defconfig
> b/arch/arm64/configs/defconfig
> index 4972a81d40d6..1363c237b6f3 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -289,6 +289,7 @@ CONFIG_SCSI_UFSHCD_PLATFORM=y
>  CONFIG_SCSI_UFS_QCOM=m
>  CONFIG_SCSI_UFS_HISI=y
>  CONFIG_SCSI_UFS_EXYNOS=y
> +CONFIG_SCSI_UFS_FBO=y
>  CONFIG_ATA=y
>  CONFIG_SATA_AHCI=y
>  CONFIG_SATA_AHCI_PLATFORM=y
> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
> index 432df76e6318..57b0e8b14543 100644
> --- a/drivers/scsi/ufs/Kconfig
> +++ b/drivers/scsi/ufs/Kconfig
> @@ -199,3 +199,12 @@ config SCSI_UFS_FAULT_INJECTION
>         help
>           Enable fault injection support in the UFS driver. This
> makes it easier
>           to test the UFS error handler and abort handler.
> +
> +config SCSI_UFS_FBO
> +       bool "Support UFS File-based Optimization"
> +       depends on SCSI_UFSHCD
> +       help
> +        The UFS FBO feature improves Sequential read performance.
> The Host can
> +        send the LBA to device. The device will return a fragmented
> state. It
> +        is up to the host to decide whether to defrag. After
> defragment,
> +        Sequential read performance is improved
> \ No newline at end of file
> diff --git a/drivers/scsi/ufs/Makefile b/drivers/scsi/ufs/Makefile
> index c407da9b5171..956be0738263 100644
> --- a/drivers/scsi/ufs/Makefile
> +++ b/drivers/scsi/ufs/Makefile
> @@ -9,6 +9,7 @@ ufshcd-core-$(CONFIG_DEBUG_FS)          += ufs-
> debugfs.o
>  ufshcd-core-$(CONFIG_SCSI_UFS_BSG)     += ufs_bsg.o
>  ufshcd-core-$(CONFIG_SCSI_UFS_CRYPTO)  += ufshcd-crypto.o
>  ufshcd-core-$(CONFIG_SCSI_UFS_HPB)     += ufshpb.o
> +ufshcd-core-$(CONFIG_SCSI_UFS_FBO)     += ufsfbo.o
>  ufshcd-core-$(CONFIG_SCSI_UFS_FAULT_INJECTION) += ufs-fault-
> injection.o
>  
>  obj-$(CONFIG_SCSI_UFS_DWC_TC_PCI) += tc-dwc-g210-pci.o ufshcd-dwc.o
> tc-dwc-g210.o
> diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
> index 8c6b38b1b142..b750ce3f7de9 100644
> --- a/drivers/scsi/ufs/ufs.h
> +++ b/drivers/scsi/ufs/ufs.h
> @@ -170,6 +170,7 @@ enum desc_idn {
>         QUERY_DESC_IDN_GEOMETRY         = 0x7,
>         QUERY_DESC_IDN_POWER            = 0x8,
>         QUERY_DESC_IDN_HEALTH           = 0x9,
> +       QUERY_DESC_IDN_FBO          = 0xA,
Hi Jiaming, 

Is this a UFS extended standard or vendor specific feature?