linux-kernel - Re: [PATCH] pci/cx18: Use 'unsigned int' instead of just 'unsigned'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de68f0cc-2151-4481-2778-da98ffd4aeb0@xs4all.nl>
Date:   Wed, 24 Aug 2022 16:56:09 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Jilin Yuan <yuanjilin@...rlc.com>, awalls@...metrocast.net,
        mchehab@...nel.org
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pci/cx18: Use 'unsigned int' instead of just 'unsigned'.

There are loads of old drivers that do this, it's not worth the effort
to change this.

Sorry.

I'll reject such patches.

Regards,

	Hans

On 24/08/2022 15:31, Jilin Yuan wrote:
> Prefer 'unsigned int' to bare use of 'unsigned'.
> 
> Signed-off-by: Jilin Yuan <yuanjilin@...rlc.com>
> ---
>  drivers/media/pci/cx18/cx18-firmware.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/pci/cx18/cx18-firmware.c b/drivers/media/pci/cx18/cx18-firmware.c
> index 1b038b2802bf..b72bcbc1fed6 100644
> --- a/drivers/media/pci/cx18/cx18-firmware.c
> +++ b/drivers/media/pci/cx18/cx18-firmware.c
> @@ -88,7 +88,7 @@ static int load_cpu_fw_direct(const char *fn, u8 __iomem *mem, struct cx18 *cx)
>  {
>  	const struct firmware *fw = NULL;
>  	int i, j;
> -	unsigned size;
> +	unsigned int size;
>  	u32 __iomem *dst = (u32 __iomem *)mem;
>  	const u32 *src;
>  
> @@ -128,7 +128,7 @@ static int load_apu_fw_direct(const char *fn, u8 __iomem *dst, struct cx18 *cx,
>  {
>  	const struct firmware *fw = NULL;
>  	int i, j;
> -	unsigned size;
> +	unsigned int size;
>  	const u32 *src;
>  	struct cx18_apu_rom_seghdr seghdr;
>  	const u8 *vers;