linux-kernel - Re: [PATCH bpf-next] selftests/bpf: fix incorrect fcntl call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQLF6SjASpwS1i0YP2NT16Ctvn0s3jeCudKimNXQdi9Ebw@mail.gmail.com>
Date:   Wed, 24 Aug 2022 08:50:49 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Mykola Lysenko <mykolal@...com>
Cc:     Qiao Ma <mqaio@...ux.alibaba.com>,
        "andrii@...nel.org" <andrii@...nel.org>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH bpf-next] selftests/bpf: fix incorrect fcntl call

On Wed, Aug 24, 2022 at 8:13 AM Mykola Lysenko <mykolal@...com> wrote:
>
> Hi Qiao,
>
> > On Aug 24, 2022, at 7:01 AM, Qiao Ma <mqaio@...ux.alibaba.com> wrote:
> >
> > !-------------------------------------------------------------------|
> >  This Message Is From an External Sender
> >
> > |-------------------------------------------------------------------!
> >
> > To set socket noblock, we need to use
> >> fcntl(fd, F_SETFL, O_NONBLOCK);
> > rather than:
> >> fcntl(fd, O_NONBLOCK);
>
> Can you please add more description on what is it fixing?
>
> Additionally, add file name to the title to make it easier to identify the commit from oneline git log.

file name in commit log? I think it's overkill.
The file names can be seen with git log --stat
Let's not put duplicate info into subjects.

> Something like “selftests/bpf: fix incorrect fcntl call (test_sockmap.c)”.