linux-kernel - Re: [PATCH drm-misc-next v2 2/4] drm/vc4: plane: protect device resources after removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bd89a246-ee32-7b54-9c9c-7090cc7d51a2@redhat.com>
Date:   Wed, 24 Aug 2022 17:58:40 +0200
From:   Danilo Krummrich <dakr@...hat.com>
To:     Maxime Ripard <maxime@...no.tech>
Cc:     airlied@...ux.ie, dri-devel@...ts.freedesktop.org,
        tzimmermann@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH drm-misc-next v2 2/4] drm/vc4: plane: protect device
 resources after removal

Hi Maxime,

On 8/24/22 17:48, Maxime Ripard wrote:
>> @@ -1252,12 +1261,17 @@ void vc4_plane_async_set_fb(struct drm_plane *plane, struct drm_framebuffer *fb)
>>   	WARN_ON_ONCE(plane->state->crtc_x < 0 || plane->state->crtc_y < 0);
>>   	addr = bo->dma_addr + fb->offsets[0];
>>   
>> +	if (!drm_dev_enter(plane->dev, &idx))
>> +		return;
>> +
>>   	/* Write the new address into the hardware immediately.  The
>>   	 * scanout will start from this address as soon as the FIFO
>>   	 * needs to refill with pixels.
>>   	 */
>>   	writel(addr, &vc4_state->hw_dlist[vc4_state->ptr0_offset]);
>>   
>> +	drm_dev_exit(idx);
>> +
> 
> You did change the CRTC patch, but the comment to protect the entire
> function also applies to this one.

Yes, I changed this one too, but missed this particular function - gonna 
send a v3.

- Danilo

> 
> Maxime