linux-kernel - RE: [PATCH v1 5/9] crypto/ycc: Add skcipher algorithm support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW5PR84MB1842B41754897B029B6949E5AB739@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
Date:   Wed, 24 Aug 2022 16:24:35 +0000
From:   "Elliott, Robert (Servers)" <elliott@....com>
To:     'Guanjun' <guanjun@...ux.alibaba.com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>
CC:     "zelin.deng@...ux.alibaba.com" <zelin.deng@...ux.alibaba.com>,
        "xuchun.shang@...ux.alibaba.com" <xuchun.shang@...ux.alibaba.com>,
        "artie.ding@...ux.alibaba.com" <artie.ding@...ux.alibaba.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v1 5/9] crypto/ycc: Add skcipher algorithm support



> -----Original Message-----
> From: 'Guanjun' <guanjun@...ux.alibaba.com>
> Sent: Wednesday, August 24, 2022 4:50 AM
> Subject: [PATCH v1 5/9] crypto/ycc: Add skcipher algorithm support
> 
...

> +static struct skcipher_alg ycc_skciphers[] = {
> +	{
> +		.base = {
> +			.cra_name = "cbc(aes)",
> +			.cra_driver_name = "ycc_cbc(aes)",

In comparison, the aead driver puts the hardware driver name as a suffix,
not a prefix, and uses dashes rather than underscores and parenthesis:
> +			.cra_name = "gcm(aes)",
> +			.cra_driver_name = "gcm-aes-ycc",

and the pk driver uses a prefix with a dash:
> +		.cra_name = "rsa",
> +		.cra_driver_name = "ycc-rsa",

Although the existing drivers are wildly inconsistent, it would be nice
if this driver was at least consistent with itself. Suffixes with dashes
seem to be the most popular, so consider these formats:
  cbc-aes-ycc
  gcm-aes-ycc
  rsa-ycc