lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Aug 2022 09:35:48 -0700 From: Bart Van Assche <bvanassche@....org> To: Jiaming Li <lijiamingsofine@...il.com>, avri.altman@....com, alim.akhtar@...sung.com, jejb@...ux.ibm.com Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, lijiaming3 <lijiaming3@...omi.com> Subject: Re: [PATCH] scsi: ufs: ufsfbo: Introduce File Based Optimization feature On 8/24/22 01:46, Jiaming Li wrote: > +#include "../../../block/blk.h" Without having taken a look at the rest of this patch, including a block driver private header file in the UFS driver is unacceptable. > +#define FBO_INFO_MSG(fbo, msg, args...) do { \ > + if (fbo->fbo_debug) \ > + pr_info("[info]%s:%d:" msg "\n", __func__, __LINE__, ##args); \ > + } while (0) Please use pr_debug() instead. > +#define FBO_ERR_MSG(msg, args...) \ > + pr_err("[err]%s:%d:" msg "\n", __func__, __LINE__, ##args) Please use pr_err() directly and remove the function name and line numbers from error messages. > +#define FBO_WARN_MSG(msg, args...) \ > + pr_warn("[warn]%s:%d:" msg "\n", __func__, __LINE__, ##args) Please use pr_warn directly and remove function name and line numbers from warning messages. Thanks, Bart.
Powered by blists - more mailing lists