linux-kernel - Re: [PATCH v9 1/6] x86/tdx: Add TDX Guest attestation interface driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9519f3eb-9efd-b596-4331-e62ada389e1e@linux.intel.com>
Date:   Wed, 24 Aug 2022 09:56:43 -0700
From:   Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Dave Hansen <dave.hansen@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H . Peter Anvin" <hpa@...or.com>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Tony Luck <tony.luck@...el.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kai Huang <kai.huang@...el.com>,
        Wander Lairson Costa <wander@...hat.com>,
        Isaku Yamahata <isaku.yamahata@...il.com>,
        marcelo.cerri@...onical.com, tim.gardner@...onical.com,
        khalid.elmously@...onical.com, philip.cox@...onical.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 1/6] x86/tdx: Add TDX Guest attestation interface
 driver



On 8/24/22 8:56 AM, Borislav Petkov wrote:
> On Mon, Aug 22, 2022 at 03:41:00PM -0700, Sathyanarayanan Kuppuswamy wrote:
>> In addition to above, I think there is a possibility to add IOCTL to get
>> storage keys from the ACPI SVKL table. Storage Volume Key Table (SVKL) is
>> used by the VBIOS to share keys required to access encrypted drives. Although
>> we don't have a clear requirement, I suspect that we might add IOCTL for it.
> 
> So this all sounds like a single tdx-guest driver to me which services a
> bunch of ioctls... not separate drivers.
> 
> Hmm?

Yes. You are right. This is similar to AMD sev-guest driver. 

https://github.com/torvalds/linux/blob/master/drivers/virt/coco/sev-guest/sev-guest.c

> 

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer