linux-kernel - Re: [PATCH v13 36/70] xtensa: remove vma linked list walks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220825154830.jb46malqyy3qme3e@offworld>
Date:   Thu, 25 Aug 2022 08:48:30 -0700
From:   Davidlohr Bueso <dave@...olabs.net>
To:     Liam Howlett <liam.howlett@...cle.com>
Cc:     "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>
Subject: Re: [PATCH v13 36/70] xtensa: remove vma linked list walks

On Mon, 22 Aug 2022, Liam Howlett wrote:

>From: "Matthew Wilcox (Oracle)" <willy@...radead.org>
>
>Use the VMA iterator instead.  Since VMA can no longer be NULL in the
>loop, then deal with out-of-memory outside the loop.  This means a
>slightly longer run time in the failure case (-ENOMEM) - it will run to
>the end of the VMAs before erroring instead of in the middle of the loop.

I don't see anyone minding this.

>
>Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
>Signed-off-by: Liam R. Howlett <Liam.Howlett@...cle.com>

Reviewed-by: Davidlohr Bueso <dave@...olabs.net>