linux-kernel - Re: [PATCH] staging: sm750fb: split multiple assignments to lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ywa/TiT46IH4vDw0@valhalla>
Date:   Wed, 24 Aug 2022 20:16:14 -0400
From:   Chris Carbone <chris.m.carbone@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
        linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: sm750fb: split multiple assignments to lines

On Tue, Aug 23, 2022 at 08:26:44AM +0200, Greg KH wrote:
> On Mon, Aug 22, 2022 at 06:42:48PM -0400, Christopher Carbone wrote:
> > 
> > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> > index dbd1159a2ef0..6f4c31635cc4 100644
> > --- a/drivers/staging/sm750fb/sm750.c
> > +++ b/drivers/staging/sm750fb/sm750.c
> > @@ -386,7 +386,8 @@ static int lynxfb_ops_set_par(struct fb_info *info)
> >  
> >  	ret = lynxfb_set_color_offsets(info);
> >  
> > -	var->height = var->width = -1;
> > +	var->height  = -1;
> 
> Odd spacing on this new line.  Did you run your change through
> checkpatch?

Yes; checkpatch didn't report any problems with it.

Thank you for your time,
Chris Carbone