| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <065601d8b8a7$6fee5850$4fcb08f0$@samsung.com>
Date: Thu, 25 Aug 2022 22:53:44 +0530
From: "Alim Akhtar" <alim.akhtar@...sung.com>
To: "'Ard Biesheuvel'" <ardb@...nel.org>,
<linux-kernel@...r.kernel.org>
Cc: "'Alan Stern'" <stern@...land.harvard.edu>,
"'Greg Kroah-Hartman'" <gregkh@...uxfoundation.org>,
"'Nicolas Ferre'" <nicolas.ferre@...rochip.com>,
"'Alexandre Belloni'" <alexandre.belloni@...tlin.com>,
"'Claudiu Beznea'" <claudiu.beznea@...rochip.com>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
"'Avi Fishman'" <avifishman70@...il.com>,
"'Tomer Maimon'" <tmaimon77@...il.com>,
"'Tali Perry'" <tali.perry1@...il.com>,
"'Patrick Venture'" <venture@...gle.com>,
"'Nancy Yuen'" <yuenn@...gle.com>,
"'Benjamin Fair'" <benjaminfair@...gle.com>,
"'Patrice Chotard'" <patrice.chotard@...s.st.com>,
"'Vladimir Zapolskiy'" <vz@...ia.com>, <linux-usb@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-samsung-soc@...r.kernel.org>, <linux-omap@...r.kernel.org>
Subject: RE: [RFC PATCH] usb: reduce kernel log spam on driver registration
>-----Original Message-----
>From: Ard Biesheuvel [mailto:ardb@...nel.org]
>Sent: Thursday, August 25, 2022 10:33 PM
>To: linux-kernel@...r.kernel.org
>Cc: Ard Biesheuvel <ardb@...nel.org>; Alan Stern
><stern@...land.harvard.edu>; Greg Kroah-Hartman
><gregkh@...uxfoundation.org>; Nicolas Ferre
><nicolas.ferre@...rochip.com>; Alexandre Belloni
><alexandre.belloni@...tlin.com>; Claudiu Beznea
><claudiu.beznea@...rochip.com>; Krzysztof Kozlowski
><krzysztof.kozlowski@...aro.org>; Alim Akhtar <alim.akhtar@...sung.com>;
>Avi Fishman <avifishman70@...il.com>; Tomer Maimon
><tmaimon77@...il.com>; Tali Perry <tali.perry1@...il.com>; Patrick
>Venture <venture@...gle.com>; Nancy Yuen <yuenn@...gle.com>;
>Benjamin Fair <benjaminfair@...gle.com>; Patrice Chotard
><patrice.chotard@...s.st.com>; Vladimir Zapolskiy <vz@...ia.com>; linux-
>usb@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-samsung-
>soc@...r.kernel.org; linux-omap@...r.kernel.org
>Subject: [RFC PATCH] usb: reduce kernel log spam on driver registration
>
>Drivers are typically supposed to be quiet unless they are actually probed,
but
>for some reason, USB host controllers seem to be exempt from this rule, and
>happily broadcast their existence into the kernel log at boot even if the
>hardware in question is nowhere to be found.
>
>Let's fix that, and remove these pr_info() calls.
>
How about just change pr_info() to pr_debug() instead?
>Cc: Alan Stern <stern@...land.harvard.edu>
>Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>
>Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
>Cc: Claudiu Beznea <claudiu.beznea@...rochip.com>
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>Cc: Alim Akhtar <alim.akhtar@...sung.com>
>Cc: Avi Fishman <avifishman70@...il.com>
>Cc: Tomer Maimon <tmaimon77@...il.com>
>Cc: Tali Perry <tali.perry1@...il.com>
>Cc: Patrick Venture <venture@...gle.com>
>Cc: Nancy Yuen <yuenn@...gle.com>
>Cc: Benjamin Fair <benjaminfair@...gle.com>
>Cc: Patrice Chotard <patrice.chotard@...s.st.com>
>Cc: Vladimir Zapolskiy <vz@...ia.com>
>Cc: linux-usb@...r.kernel.org
>Cc: linux-arm-kernel@...ts.infradead.org
>Cc: linux-kernel@...r.kernel.org
>Cc: linux-samsung-soc@...r.kernel.org
>Cc: linux-omap@...r.kernel.org
>Signed-off-by: Ard Biesheuvel <ardb@...nel.org>
>---
> drivers/usb/host/ehci-atmel.c | 1 -
> drivers/usb/host/ehci-exynos.c | 1 -
> drivers/usb/host/ehci-fsl.c | 2 --
> drivers/usb/host/ehci-hcd.c | 1 -
> drivers/usb/host/ehci-npcm7xx.c | 2 --
> drivers/usb/host/ehci-omap.c | 2 --
> drivers/usb/host/ehci-orion.c | 2 --
> drivers/usb/host/ehci-pci.c | 2 --
> drivers/usb/host/ehci-platform.c | 2 --
> drivers/usb/host/ehci-spear.c | 2 --
> drivers/usb/host/ehci-st.c | 2 --
> drivers/usb/host/fotg210-hcd.c | 1 -
> drivers/usb/host/ohci-at91.c | 1 -
> drivers/usb/host/ohci-da8xx.c | 1 -
> drivers/usb/host/ohci-exynos.c | 1 -
> drivers/usb/host/ohci-hcd.c | 1 -
> drivers/usb/host/ohci-nxp.c | 2 --
> drivers/usb/host/ohci-omap.c | 2 --
> drivers/usb/host/ohci-pci.c | 2 --
> drivers/usb/host/ohci-platform.c | 2 --
> drivers/usb/host/ohci-pxa27x.c | 2 --
> drivers/usb/host/ohci-s3c2410.c | 1 -
> drivers/usb/host/ohci-spear.c | 2 --
> drivers/usb/host/ohci-st.c | 2 --
> 24 files changed, 39 deletions(-)
>
>diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c
>index 05d41fd65f25..0e995019c1df 100644
>--- a/drivers/usb/host/ehci-atmel.c
>+++ b/drivers/usb/host/ehci-atmel.c
>@@ -239,7 +239,6 @@ static int __init ehci_atmel_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
> ehci_init_driver(&ehci_atmel_hc_driver,
>&ehci_atmel_drv_overrides);
> return platform_driver_register(&ehci_atmel_driver);
> }
>diff --git a/drivers/usb/host/ehci-exynos.c
b/drivers/usb/host/ehci-exynos.c
>index 1a9b7572e17f..a65e365e3a04 100644
>--- a/drivers/usb/host/ehci-exynos.c
>+++ b/drivers/usb/host/ehci-exynos.c
>@@ -347,7 +347,6 @@ static int __init ehci_exynos_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
> ehci_init_driver(&exynos_ehci_hc_driver, &exynos_overrides);
> return platform_driver_register(&exynos_ehci_driver);
> }
>diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index
>896c0d107f72..9cea785934e5 100644
>--- a/drivers/usb/host/ehci-fsl.c
>+++ b/drivers/usb/host/ehci-fsl.c
>@@ -722,8 +722,6 @@ static int __init ehci_fsl_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info(DRV_NAME ": " DRIVER_DESC "\n");
>-
> ehci_init_driver(&fsl_ehci_hc_driver, &ehci_fsl_overrides);
>
> fsl_ehci_hc_driver.product_desc =
>diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index
>684164fa9716..a1930db0da1c 100644
>--- a/drivers/usb/host/ehci-hcd.c
>+++ b/drivers/usb/host/ehci-hcd.c
>@@ -1351,7 +1351,6 @@ static int __init ehci_hcd_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- printk(KERN_INFO "%s: " DRIVER_DESC "\n", hcd_name);
> set_bit(USB_EHCI_LOADED, &usb_hcds_loaded);
> if (test_bit(USB_UHCI_LOADED, &usb_hcds_loaded) ||
> test_bit(USB_OHCI_LOADED, &usb_hcds_loaded))
>diff --git a/drivers/usb/host/ehci-npcm7xx.c b/drivers/usb/host/ehci-
>npcm7xx.c index 6b5a7a873e01..4321ac6b11cc 100644
>--- a/drivers/usb/host/ehci-npcm7xx.c
>+++ b/drivers/usb/host/ehci-npcm7xx.c
>@@ -191,8 +191,6 @@ static int __init ehci_npcm7xx_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
>-
> ehci_init_driver(&ehci_npcm7xx_hc_driver, NULL);
> return platform_driver_register(&npcm7xx_ehci_hcd_driver);
> }
>diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
>index 8c45bc17a580..7dd984722a7f 100644
>--- a/drivers/usb/host/ehci-omap.c
>+++ b/drivers/usb/host/ehci-omap.c
>@@ -284,8 +284,6 @@ static int __init ehci_omap_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
>-
> ehci_init_driver(&ehci_omap_hc_driver, &ehci_omap_overrides);
> return platform_driver_register(&ehci_hcd_omap_driver);
> }
>diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
>index 3626758b3e2a..2c8b1e6f1fff 100644
>--- a/drivers/usb/host/ehci-orion.c
>+++ b/drivers/usb/host/ehci-orion.c
>@@ -361,8 +361,6 @@ static int __init ehci_orion_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
>-
> ehci_init_driver(&ehci_orion_hc_driver, &orion_overrides);
> return platform_driver_register(&ehci_orion_driver);
> }
>diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
index
>9937c5a7efc2..9581952d999a 100644
>--- a/drivers/usb/host/ehci-pci.c
>+++ b/drivers/usb/host/ehci-pci.c
>@@ -423,8 +423,6 @@ static int __init ehci_pci_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
>-
> ehci_init_driver(&ehci_pci_hc_driver, &pci_overrides);
>
> /* Entries for the PCI suspend/resume callbacks are special */ diff
--git
>a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
>index 6924f0316e9a..50491eea9409 100644
>--- a/drivers/usb/host/ehci-platform.c
>+++ b/drivers/usb/host/ehci-platform.c
>@@ -529,8 +529,6 @@ static int __init ehci_platform_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
>-
> ehci_init_driver(&ehci_platform_hc_driver, &platform_overrides);
> return platform_driver_register(&ehci_platform_driver);
> }
>diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c
>index 3694e450a11a..13369289d9cc 100644
>--- a/drivers/usb/host/ehci-spear.c
>+++ b/drivers/usb/host/ehci-spear.c
>@@ -167,8 +167,6 @@ static int __init ehci_spear_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
>-
> ehci_init_driver(&ehci_spear_hc_driver, &spear_overrides);
> return platform_driver_register(&spear_ehci_hcd_driver);
> }
>diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c index
>f74433aac948..1086078133f8 100644
>--- a/drivers/usb/host/ehci-st.c
>+++ b/drivers/usb/host/ehci-st.c
>@@ -346,8 +346,6 @@ static int __init ehci_platform_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
>-
> ehci_init_driver(&ehci_platform_hc_driver, &platform_overrides);
> return platform_driver_register(&ehci_platform_driver);
> }
>diff --git a/drivers/usb/host/fotg210-hcd.c
b/drivers/usb/host/fotg210-hcd.c
>index f8c111e08a0d..3d1dbcf4c073 100644
>--- a/drivers/usb/host/fotg210-hcd.c
>+++ b/drivers/usb/host/fotg210-hcd.c
>@@ -5692,7 +5692,6 @@ static int __init fotg210_hcd_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
> set_bit(USB_EHCI_LOADED, &usb_hcds_loaded);
> if (test_bit(USB_UHCI_LOADED, &usb_hcds_loaded) ||
> test_bit(USB_OHCI_LOADED, &usb_hcds_loaded))
>diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
index
>98326465e2dc..adf0998f0299 100644
>--- a/drivers/usb/host/ohci-at91.c
>+++ b/drivers/usb/host/ohci-at91.c
>@@ -699,7 +699,6 @@ static int __init ohci_at91_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
> ohci_init_driver(&ohci_at91_hc_driver, &ohci_at91_drv_overrides);
>
> /*
>diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c
>index 1371b0c249ec..d4818e8d652b 100644
>--- a/drivers/usb/host/ohci-da8xx.c
>+++ b/drivers/usb/host/ohci-da8xx.c
>@@ -551,7 +551,6 @@ static int __init ohci_da8xx_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", DRV_NAME);
> ohci_init_driver(&ohci_da8xx_hc_driver, &da8xx_overrides);
>
> /*
>diff --git a/drivers/usb/host/ohci-exynos.c
b/drivers/usb/host/ohci-exynos.c
>index 5f5e8a64c8e2..a060be6ae274 100644
>--- a/drivers/usb/host/ohci-exynos.c
>+++ b/drivers/usb/host/ohci-exynos.c
>@@ -310,7 +310,6 @@ static int __init ohci_exynos_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
> ohci_init_driver(&exynos_ohci_hc_driver, &exynos_overrides);
> return platform_driver_register(&exynos_ohci_driver);
> }
>diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
index
>c4c821c2288c..0457dd9f6c19 100644
>--- a/drivers/usb/host/ohci-hcd.c
>+++ b/drivers/usb/host/ohci-hcd.c
>@@ -1276,7 +1276,6 @@ static int __init ohci_hcd_mod_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- printk(KERN_INFO "%s: " DRIVER_DESC "\n", hcd_name);
> pr_debug ("%s: block sizes: ed %zd td %zd\n", hcd_name,
> sizeof (struct ed), sizeof (struct td));
> set_bit(USB_OHCI_LOADED, &usb_hcds_loaded); diff --git
>a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c index
>106a6bcefb08..5b32e683e367 100644
>--- a/drivers/usb/host/ohci-nxp.c
>+++ b/drivers/usb/host/ohci-nxp.c
>@@ -275,8 +275,6 @@ static int __init ohci_nxp_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
>-
> ohci_init_driver(&ohci_nxp_hc_driver, NULL);
> return platform_driver_register(&ohci_hcd_nxp_driver);
> }
>diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c
>index f5bc9c8bdc9a..cb29701df911 100644
>--- a/drivers/usb/host/ohci-omap.c
>+++ b/drivers/usb/host/ohci-omap.c
>@@ -423,8 +423,6 @@ static int __init ohci_omap_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
>-
> ohci_init_driver(&ohci_omap_hc_driver, &omap_overrides);
> return platform_driver_register(&ohci_hcd_omap_driver);
> }
>diff --git a/drivers/usb/host/ohci-pci.c b/drivers/usb/host/ohci-pci.c
index
>41efe927d8f3..a146b2d3ef0b 100644
>--- a/drivers/usb/host/ohci-pci.c
>+++ b/drivers/usb/host/ohci-pci.c
>@@ -306,8 +306,6 @@ static int __init ohci_pci_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
>-
> ohci_init_driver(&ohci_pci_hc_driver, &pci_overrides);
>
> #ifdef CONFIG_PM
>diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-
>platform.c
>index 0adae6265127..6d56b52966c7 100644
>--- a/drivers/usb/host/ohci-platform.c
>+++ b/drivers/usb/host/ohci-platform.c
>@@ -346,8 +346,6 @@ static int __init ohci_platform_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
>-
> ohci_init_driver(&ohci_platform_hc_driver, &platform_overrides);
> return platform_driver_register(&ohci_platform_driver);
> }
>diff --git a/drivers/usb/host/ohci-pxa27x.c
b/drivers/usb/host/ohci-pxa27x.c
>index ab4f610a0140..f2504b884e92 100644
>--- a/drivers/usb/host/ohci-pxa27x.c
>+++ b/drivers/usb/host/ohci-pxa27x.c
>@@ -608,8 +608,6 @@ static int __init ohci_pxa27x_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
>-
> ohci_init_driver(&ohci_pxa27x_hc_driver, &pxa27x_overrides);
> ohci_pxa27x_hc_driver.hub_control = pxa27x_ohci_hub_control;
>
>diff --git a/drivers/usb/host/ohci-s3c2410.c
b/drivers/usb/host/ohci-s3c2410.c
>index 12264c048601..7207c7a3cf49 100644
>--- a/drivers/usb/host/ohci-s3c2410.c
>+++ b/drivers/usb/host/ohci-s3c2410.c
>@@ -474,7 +474,6 @@ static int __init ohci_s3c2410_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
> ohci_init_driver(&ohci_s3c2410_hc_driver, NULL);
>
> /*
>diff --git a/drivers/usb/host/ohci-spear.c b/drivers/usb/host/ohci-spear.c
>index 9b81f420656d..71a3f18fe1be 100644
>--- a/drivers/usb/host/ohci-spear.c
>+++ b/drivers/usb/host/ohci-spear.c
>@@ -179,8 +179,6 @@ static int __init ohci_spear_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
>-
> ohci_init_driver(&ohci_spear_hc_driver, &spear_overrides);
> return platform_driver_register(&spear_ohci_hcd_driver);
> }
>diff --git a/drivers/usb/host/ohci-st.c b/drivers/usb/host/ohci-st.c index
>ac796ccd93ef..2e542a344aae 100644
>--- a/drivers/usb/host/ohci-st.c
>+++ b/drivers/usb/host/ohci-st.c
>@@ -324,8 +324,6 @@ static int __init ohci_platform_init(void)
> if (usb_disabled())
> return -ENODEV;
>
>- pr_info("%s: " DRIVER_DESC "\n", hcd_name);
>-
> ohci_init_driver(&ohci_platform_hc_driver, &platform_overrides);
> return platform_driver_register(&ohci_platform_driver);
> }
>--
>2.35.1
Powered by blists - more mailing lists