linux-kernel - Re: [PATCH linux-next] ACPI: bus: Remove the unneeded result variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 Aug 2022 20:48:46 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     cgel.zte@...il.com
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] ACPI: bus: Remove the unneeded result variable

On Wed, Aug 24, 2022 at 9:53 AM <cgel.zte@...il.com> wrote:
>
> From: ye xingchen <ye.xingchen@....com.cn>
>
> Return the value from driver_register() directly instead of storing it
>  in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
>  drivers/acpi/bus.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index c0d20d997891..661a63ea3248 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -973,16 +973,13 @@ EXPORT_SYMBOL_GPL(acpi_driver_match_device);
>   */
>  int acpi_bus_register_driver(struct acpi_driver *driver)
>  {
> -       int ret;
> -
>         if (acpi_disabled)
>                 return -ENODEV;
>         driver->drv.name = driver->name;
>         driver->drv.bus = &acpi_bus_type;
>         driver->drv.owner = driver->owner;
>
> -       ret = driver_register(&driver->drv);
> -       return ret;
> +       return driver_register(&driver->drv);
>  }
>
>  EXPORT_SYMBOL(acpi_bus_register_driver);
> --

Applied as 6.1 material, thanks!