linux-kernel - Re: [PATCH 2/2] iio: adc: mcp320x: add triggered buffer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vda3bbsRw+mftXjrH445UqSkxcB7q9kXUc+-ODUE+VQ9g@mail.gmail.com>
Date:   Thu, 25 Aug 2022 23:06:01 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Vincent Whitchurch <vincent.whitchurch@...s.com>
Cc:     Jonathan Cameron <jic23@...nel.org>, kernel@...s.com,
        Lars-Peter Clausen <lars@...afoo.de>, axel.jonsson@...s.com,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] iio: adc: mcp320x: add triggered buffer support

On Wed, Aug 24, 2022 at 1:46 PM Vincent Whitchurch
<vincent.whitchurch@...s.com> wrote:
>
> From: Axel Jonsson <axel.jonsson@...s.com>
>
> Add support for triggered buffers.  Just read the channels in a loop to
> keep things simple.

...

>  #include <linux/module.h>
>  #include <linux/mod_devicetable.h>
>  #include <linux/iio/iio.h>
> +#include <linux/interrupt.h>

Ordering?

But honestly, I prefer the linux/iio/* to be split in a separate group...

> +#include <linux/iio/buffer.h>
> +#include <linux/iio/triggered_buffer.h>
> +#include <linux/iio/trigger_consumer.h>
>  #include <linux/regulator/consumer.h>
>

...and be put here.

...

> +       device_index = spi_get_device_id(adc->spi)->driver_data;

Hmm... Wondering if this can be derived from channel number or alike.

-- 
With Best Regards,
Andy Shevchenko