linux-kernel - Re: [PATCH] kvm: x86: mmu: fix memoryleak in kvm_mmu_vendor_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <acc676e3-8dde-89c3-a031-67c3487c8f35@huawei.com>
Date:   Thu, 25 Aug 2022 09:43:25 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Sean Christopherson <seanjc@...gle.com>
CC:     <pbonzini@...hat.com>, <tglx@...utronix.de>, <mingo@...hat.com>,
        <bp@...en8.de>, <dave.hansen@...ux.intel.com>, <x86@...nel.org>,
        <hpa@...or.com>, <kvm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kvm: x86: mmu: fix memoryleak in
 kvm_mmu_vendor_module_init()

On 2022/8/24 23:44, Sean Christopherson wrote:
> Nit for future patches, please use
> 
>   KVM: x86/mmu:
> 
> for the scope.

Will take care of it.

> 
> On Tue, Aug 23, 2022, Miaohe Lin wrote:
>> When register_shrinker() fails, we forgot to release the percpu counter
>> kvm_total_used_mmu_pages leading to memoryleak. Fix this issue by calling
>> percpu_counter_destroy() when register_shrinker() fails.
>>
>> Fixes: ab271bd4dfd5 ("x86: kvm: propagate register_shrinker return code")
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
>> ---
> 
> Reviewed-by: Sean Christopherson <seanjc@...gle.com>

Many thanks for your review.

Thanks,
Miaohe Lin