linux-kernel - Re: [PATCH 2/2] mmc: jz4740_mmc: Fix error check for dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <7807HR.GJGCCUV9UJJL3@crapouillou.net>
Date:   Thu, 25 Aug 2022 23:38:31 +0100
From:   Paul Cercueil <paul@...pouillou.net>
To:     Jack Wang <jinpu.wang@...os.com>
Cc:     ulf.hansson@...aro.org, linux-mmc@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mmc: jz4740_mmc: Fix error check for dma_map_sg

Hi Jack,

Le jeu., août 25 2022 at 09:40:08 +0200, Jack Wang 
<jinpu.wang@...os.com> a écrit :
> dma_map_sg return 0 on error.
> 
> Cc: Paul Cercueil <paul@...pouillou.net>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Cc: linux-mips@...r.kernel.org
> Cc: linux-mmc@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> 
> Signed-off-by: Jack Wang <jinpu.wang@...os.com>

Acked-by: Paul Cercueil <paul@...pouillou.net>

Cheers,
-Paul

> ---
>  drivers/mmc/host/jz4740_mmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/jz4740_mmc.c 
> b/drivers/mmc/host/jz4740_mmc.c
> index b1d563b2ed1b..dc2db9c185ea 100644
> --- a/drivers/mmc/host/jz4740_mmc.c
> +++ b/drivers/mmc/host/jz4740_mmc.c
> @@ -298,7 +298,7 @@ static int jz4740_mmc_prepare_dma_data(struct 
> jz4740_mmc_host *host,
>  {
>  	struct dma_chan *chan = jz4740_mmc_get_dma_chan(host, data);
>  	enum dma_data_direction dir = mmc_get_dma_dir(data);
> -	int sg_count;
> +	unsigned int sg_count;
> 
>  	if (data->host_cookie == COOKIE_PREMAPPED)
>  		return data->sg_count;
> @@ -308,7 +308,7 @@ static int jz4740_mmc_prepare_dma_data(struct 
> jz4740_mmc_host *host,
>  			data->sg_len,
>  			dir);
> 
> -	if (sg_count <= 0) {
> +	if (!sg_count) {
>  		dev_err(mmc_dev(host->mmc),
>  			"Failed to map scatterlist for DMA operation\n");
>  		return -EINVAL;
> --
> 2.34.1
>