linux-kernel - Re: [PATCH linux-next v2] drm/mediatek: Remove the unneeded result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Aug 2022 07:38:51 +0800
From:   Chun-Kuang Hu <chunkuang.hu@...nel.org>
To:     cgel.zte@...il.com
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next v2] drm/mediatek: Remove the unneeded result

Hi, cgel:

<cgel.zte@...il.com> 於 2022年8月25日 週四 下午3:24寫道：
>
> From: ye xingchen <ye.xingchen@....com.cn>
>
> Return the value drm_mode_config_helper_suspend() directly instead of
>  storing it in another redundant variable.

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
> v1 -> v2
> Add all the mailinglists that get_maintainers.pl give.
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 5f02f8d0e4fc..91f58db5915f 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
>  {
>         struct mtk_drm_private *private = dev_get_drvdata(dev);
>         struct drm_device *drm = private->drm;
> -       int ret;
> -
> -       ret = drm_mode_config_helper_suspend(drm);
>
> -       return ret;
> +       return drm_mode_config_helper_suspend(drm);
>  }
>
>  static void mtk_drm_sys_complete(struct device *dev)
> --
> 2.25.1