linux-kernel - Re: [PATCH v3 4/5] EDAC/qcom: Remove extra error no assignment in qcom_llcc_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e4c6449-e6d0-46fe-f413-46d2445ea82f@quicinc.com>
Date:   Thu, 25 Aug 2022 10:15:31 +0530
From:   Sai Prakash Ranjan <quic_saipraka@...cinc.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        <bjorn.andersson@...aro.org>, <bp@...en8.de>, <mchehab@...nel.org>
CC:     <james.morse@....com>, <rric@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-edac@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_tsoni@...cinc.com>
Subject: Re: [PATCH v3 4/5] EDAC/qcom: Remove extra error no assignment in
 qcom_llcc_core_setup()

On 8/25/2022 10:08 AM, Manivannan Sadhasivam wrote:
> If the ret variable is initialized with -EINVAL, then there is no need to
> assign it again in the default case of qcom_llcc_core_setup().

Nit: I think you meant in qcom_llcc_clear_error_status().

>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> ---
>   drivers/edac/qcom_edac.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Sai Prakash Ranjan <quic_saipraka@...cinc.com>

> diff --git a/drivers/edac/qcom_edac.c b/drivers/edac/qcom_edac.c
> index 04df70b7fea3..0b6ca1f20b51 100644
> --- a/drivers/edac/qcom_edac.c
> +++ b/drivers/edac/qcom_edac.c
> @@ -126,7 +126,7 @@ static int qcom_llcc_core_setup(struct llcc_drv_data *drv, struct regmap *llcc_b
>   static int
>   qcom_llcc_clear_error_status(int err_type, struct llcc_drv_data *drv)
>   {
> -	int ret = 0;
> +	int ret = -EINVAL;
>   
>   	switch (err_type) {
>   	case LLCC_DRAM_CE:
> @@ -158,7 +158,6 @@ qcom_llcc_clear_error_status(int err_type, struct llcc_drv_data *drv)
>   			return ret;
>   		break;
>   	default:
> -		ret = -EINVAL;
>   		edac_printk(KERN_CRIT, EDAC_LLCC, "Unexpected error type: %d\n",
>   			    err_type);
>   	}