linux-kernel - [PATCH -next] regulator: drivers: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220825070438.128093-1-yang.lee@linux.alibaba.com>
Date:   Thu, 25 Aug 2022 15:04:38 +0800
From:   Yang Li <yang.lee@...ux.alibaba.com>
To:     tony@...mide.com
Cc:     lgirdwood@...il.com, broonie@...nel.org,
        linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yang Li <yang.lee@...ux.alibaba.com>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: [PATCH -next] regulator: drivers: Remove unnecessary print function dev_err()

The print function dev_err() is redundant because
platform_get_irq_byname() already prints an error.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1986
Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
---
 drivers/regulator/tps65219-regulator.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/tps65219-regulator.c b/drivers/regulator/tps65219-regulator.c
index 7ba2594e437c..ab16e6665625 100644
--- a/drivers/regulator/tps65219-regulator.c
+++ b/drivers/regulator/tps65219-regulator.c
@@ -363,11 +363,9 @@ static int tps65219_regulator_probe(struct platform_device *pdev)
 		irq_type = &tps65219_regulator_irq_types[i];
 
 		irq = platform_get_irq_byname(pdev, irq_type->irq_name);
-		if (irq < 0) {
-			dev_err(tps->dev, "Failed to get IRQ %s: %d\n",
-				irq_type->irq_name, irq);
+		if (irq < 0)
 			return -EINVAL;
-		}
+
 		irq_data[i].dev = tps->dev;
 		irq_data[i].type = irq_type;
 
-- 
2.20.1.7.g153144c